Re: [PATCH v2 2/6] mtd: rawnand: tegra: add devicetree binding

[Miquel Raynal]

Hi Rob,

On Wed, 30 May 2018 22:45:23 -0500, Rob Herring <robh@xxxxxxxxxx> wrote:

> On Mon, May 28, 2018 at 12:23:54AM +0200, Miquel Raynal wrote:
> > Hi Stefan,
> > 
> > On Sun, 27 May 2018 23:54:38 +0200, Stefan Agner <stefan@xxxxxxxx>
> > wrote:
> >   
> > > From: Lucas Stach <dev@xxxxxxxxxx>
> > > 
> > > This adds the devicetree binding for the Tegra 2 NAND flash
> > > controller.
> > > 
> > > Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> > > Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> > > ---
> > >  .../bindings/mtd/nvidia,tegra20-nand.txt      | 62 +++++++++++++++++++
> > >  1 file changed, 62 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > > new file mode 100644
> > > index 000000000000..49e472af1b39
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > > @@ -0,0 +1,62 @@
> > > +NVIDIA Tegra NAND Flash controller
> > > +
> > > +Required properties:
> > > +- compatible: Must be one of:  
> > 
> > Nitpick: just put the compatible here as there is only one?  
> 
> No, this is how I ask people to format it.

Oh, ok, I'll remember it for my own DT patches then :)

Thanks,
MiquÃl