Re: [PATCH] lib/plist.c: Export plist_*() APIs

From: Hareesh Gundu
Date: Wed May 30 2018 - 08:25:15 EST




On 12/6/2017 9:29 PM, Peter Zijlstra wrote:
On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote:
On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
Allow plist_add(), plist_del() and plist_requeue() APIs to
be referenced by kernel modules by adding the EXPORT_SYMBOL().
This change is not for in-tree kernel module. It's for modules built outside
of kernel tree modules.

Is it really required to show out tree kernel modules ?
Typically we don't add EXPORTs for functions not used in in-tree
modules.
We changed our design and planned to have our module in-tree kernel instead of out tree kernel module.
Below is the reference for in-tree kernel module proposal for "drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.