Re: [PATCH v2 5/5] arm64: dts: renesas: r8a7795: add ccree binding

From: Simon Horman
Date: Wed May 30 2018 - 05:28:28 EST


On Thu, May 24, 2018 at 03:19:10PM +0100, Gilad Ben-Yossef wrote:
> Add bindings for CryptoCell instance in the SoC.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>

In so far as I can review the details of this (which is not much) this
looks fine to me. I am, however, a little unclear in when it should be
accepted.

> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index d842940..3ac75db 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -528,6 +528,15 @@
> status = "disabled";
> };
>
> + arm_cc630p: crypto@e6601000 {
> + compatible = "arm,cryptocell-630p-ree";
> + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0 0xe6601000 0 0x1000>;
> + clocks = <&cpg CPG_MOD 229>;
> + resets = <&cpg 229>;
> + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + };
> +
> i2c3: i2c@e66d0000 {
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.7.4
>