[PATCH rebase] f2fs-tools: fix overflow bug of start_sector when computing zone_align_start_offset

From: Yunlong Song
Date: Wed May 30 2018 - 03:00:35 EST


zone_align_start_offset should be u64, but config.start_sector is u32,
so it may be overflow when computing zone_align_start_offset.

Signed-off-by: Yunlong Song <yunlong.song@xxxxxxxxxx>
---
fsck/resize.c | 7 ++++---
mkfs/f2fs_format.c | 4 ++--
2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/fsck/resize.c b/fsck/resize.c
index 649f5d9..3f8b01d 100644
--- a/fsck/resize.c
+++ b/fsck/resize.c
@@ -11,7 +11,8 @@

static int get_new_sb(struct f2fs_super_block *sb)
{
- u_int32_t zone_size_bytes, zone_align_start_offset;
+ u_int32_t zone_size_bytes;
+ u_int64_t zone_align_start_offset;
u_int32_t blocks_for_sit, blocks_for_nat, blocks_for_ssa;
u_int32_t sit_segments, nat_segments, diff, total_meta_segments;
u_int32_t total_valid_blks_available;
@@ -27,10 +28,10 @@ static int get_new_sb(struct f2fs_super_block *sb)

zone_size_bytes = segment_size_bytes * segs_per_zone;
zone_align_start_offset =
- (c.start_sector * DEFAULT_SECTOR_SIZE +
+ ((u_int64_t) c.start_sector * DEFAULT_SECTOR_SIZE +
2 * F2FS_BLKSIZE + zone_size_bytes - 1) /
zone_size_bytes * zone_size_bytes -
- c.start_sector * DEFAULT_SECTOR_SIZE;
+ (u_int64_t) c.start_sector * DEFAULT_SECTOR_SIZE;

set_sb(segment_count, (c.target_sectors * c.sector_size -
zone_align_start_offset) / segment_size_bytes /
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index e0c3cb8..2350c10 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -212,10 +212,10 @@ static int f2fs_prepare_super_block(void)
set_sb(block_count, c.total_sectors >> log_sectors_per_block);

zone_align_start_offset =
- (c.start_sector * DEFAULT_SECTOR_SIZE +
+ ((u_int64_t) c.start_sector * DEFAULT_SECTOR_SIZE +
2 * F2FS_BLKSIZE + zone_size_bytes - 1) /
zone_size_bytes * zone_size_bytes -
- c.start_sector * DEFAULT_SECTOR_SIZE;
+ (u_int64_t) c.start_sector * DEFAULT_SECTOR_SIZE;

if (c.start_sector % DEFAULT_SECTORS_PER_BLOCK) {
MSG(1, "\t%s: Align start sector number to the page unit\n",
--
1.8.5.2