Re: [PATCH] bpfilter: fix building without CONFIG_INET

From: David Miller
Date: Tue May 29 2018 - 08:14:31 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 29 May 2018 11:55:06 +0200

> bpfilter_process_sockopt is a callback that gets called from
> ip_setsockopt() and ip_getsockopt(). However, when CONFIG_INET is
> disabled, it never gets called at all, and assigning a function to the
> callback pointer results in a link failure:
>
> net/bpfilter/bpfilter_kern.o: In function `__stop_umh':
> bpfilter_kern.c:(.text.unlikely+0x3): undefined reference to `bpfilter_process_sockopt'
> net/bpfilter/bpfilter_kern.o: In function `load_umh':
> bpfilter_kern.c:(.init.text+0x73): undefined reference to `bpfilter_process_sockopt'
>
> Since there is no caller in this configuration, I assume we can
> simply make the assignment conditional.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied, thanks Arnd.