Re: [PATCH 3/5] scsi: ufs: Add Kconfig for UFS HC driver crypto support

[Ladvine D Almeida]

On Monday 28 May 2018 04:49 PM, Randy Dunlap wrote:
> On 05/28/2018 06:29 AM, Ladvine D Almeida wrote:
>>
>> This patch adds the Kconfig for enabling crypto support for
>> UFS Host Controller driver. It also adds Makefile changes
>> for building crypto support based on crypto Kconfig selection.
>>
>> Signed-off-by: Ladvine D Almeida <ladvine@xxxxxxxxxxxx>
>> ---
>>  drivers/scsi/ufs/Kconfig  | 15 +++++++++++++++
>>  drivers/scsi/ufs/Makefile |  6 +++++-
>>  2 files changed, 20 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>> index e27b4d4..0134672 100644
>> --- a/drivers/scsi/ufs/Kconfig
>> +++ b/drivers/scsi/ufs/Kconfig
>> @@ -50,6 +50,21 @@ config SCSI_UFSHCD
>>  	  However, do not compile this as a module if your root file system
>>  	  (the one containing the directory /) is located on a UFS device.
>>  
>> +config SCSI_UFSHCD_INLINE_ENCRYPTION
>> +	bool "Universal Flash Storage Controller Driver crypto support"
>> +	depends on SCSI_UFSHCD
>> +	default n
>> +	select BLK_DEV_INLINE_ENCRYPTION if SCSI_UFSHCD_INLINE_ENCRYPTION
>> +	help
>> +	This enables the Inline Encryption feature of the UFS Host
>> +	Controller driver. Once the capability is detected in hardware,
>> +	it will be made available for the user through Linux Kernel
>> +	Cryptography Framework(LKCF).
> 
> The help text above should be indented (as below), with one tab + 2 spaces.
> 
   Sure, I will send v2 patch with the corrected indentation.
>> +
>> +	  If you have a controller with this capability, say Y.
>> +
>> +	  If unsure, say N.
>> +
>>  config SCSI_UFSHCD_PCI
>>  	tristate "PCI bus based UFS Controller support"
>>  	depends on SCSI_UFSHCD && PCI
> 
> 

Best Regards,
Ladvine