Re: [PATCH] perf docu: Update section on cpu topology

From: Arnaldo Carvalho de Melo
Date: Mon May 28 2018 - 15:54:22 EST


Em Mon, May 28, 2018 at 09:44:33AM +0200, Thomas Richter escreveu:
> Add an explanation of each cpu's core and socket
> identifier to the documentation.

Thanks, applying. I guess it is not that worth to mention that older
files may have just the string lists, right?

- Arnaldo

> Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxx>
> ---
> tools/perf/Documentation/perf.data-file-format.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index d00f0d51cab8..c57904a526ce 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -153,10 +153,18 @@ struct {
> HEADER_CPU_TOPOLOGY = 13,
>
> String lists defining the core and CPU threads topology.
> +The string lists are followed by a variable length array
> +which contains core_id and socket_id of each cpu.
> +The number of entries can be determined by the size of the
> +section minus the sizes of both string lists.
>
> struct {
> struct perf_header_string_list cores; /* Variable length */
> struct perf_header_string_list threads; /* Variable length */
> + struct {
> + uint32_t core_id;
> + uint32_t socket_id;
> + } cpus[nr]; /* Variable length records */
> };
>
> Example:
> --
> 2.14.3