Re: [PATCH 10/19 v3] regulator: s2mps11: Pass descriptor instead of GPIO number

From: Linus Walleij
Date: Mon May 28 2018 - 04:41:38 EST


On Sat, May 26, 2018 at 12:02 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Mon, May 14, 2018 at 10:06:31AM +0200, Linus Walleij wrote:
>> Instead of passing a global GPIO number for the enable GPIO, pass
>> a descriptor looked up with the standard devm_gpiod_get_optional()
>> call.
>>
>> This regulator supports passing platform data, but enable/sleep
>> regulators are looked up from the device tree exclusively, so
>> we can need not touch other files.
>
> This seems to have broken the boot on Odroid XU3 so I'm going to revert
> it:
>
> https://storage.kernelci.org/next/master/v4.17-rc6-9523-g47b9cef0672d/arm/multi_v7_defconfig/lab-baylibre-seattle/boot-exynos5422-odroidxu3.html

How annoying. I will check with a colleague who might have this
board so I can test it on hardware.

Yours,
Linus Walleij