Re: [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices

From: Greg Kroah-Hartman
Date: Wed May 23 2018 - 03:34:06 EST


On Tue, May 22, 2018 at 03:28:01PM -0700, Rajat Jain wrote:
> --- /dev/null
> +++ b/drivers/pci/pcie/aer/aerdrv_stats.c
> @@ -0,0 +1,64 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018 Google Inc, All Rights Reserved.
> + * Rajat Jain (rajatja@xxxxxxxxxx)

Google has the copyright, not you, right? You might want to make that a
bit more explicit by putting a blank line somewhere here...

> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

If you have a SPDX line, you do not need this paragraph. Please drop it
so we don't have to delete it later on.

thanks,

greg k-h