Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

From: Cong Wang
Date: Tue May 22 2018 - 19:41:27 EST


On Mon, May 21, 2018 at 11:35 PM, Ivan Babrou <ibobrik@xxxxxxxxx> wrote:
>
>
> On Mon, May 21, 2018 at 11:20 PM Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>>
>> +
>> + TP_printk("path=%s cpu=%d runtime_remaining=%lld",
>> __get_str(cfs_path),
>> + __entry->cpu, __entry->runtime_remaining)
>
>
> Can you add "[ns]" as the unit to runtime_remaining? We have it in
> "sched:sched_stat_runtime".

Hmm, although it is indeed ns, this ->runtime_remaining can be negative,
unlike sched_stat_runtime. So I am not sure if I should marked it as "[ns]".