Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

From: Joonsoo Kim
Date: Tue May 22 2018 - 19:15:16 EST


2018-05-23 9:02 GMT+09:00 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> On Mon, 21 May 2018 15:16:33 +0900 Joonsoo Kim <js1304@xxxxxxxxx> wrote:
>
>> > (gdb) list *(dma_direct_alloc+0x22f)
>> > 0x573fbf is in dma_direct_alloc (../lib/dma-direct.c:104).
>> > 94
>> > 95 if (!page)
>> > 96 return NULL;
>> > 97 ret = page_address(page);
>> > 98 if (force_dma_unencrypted()) {
>> > 99 set_memory_decrypted((unsigned long)ret, 1 << page_order);
>> > 100 *dma_handle = __phys_to_dma(dev, page_to_phys(page));
>> > 101 } else {
>> > 102 *dma_handle = phys_to_dma(dev, page_to_phys(page));
>> > 103 }
>> > 104 memset(ret, 0, size);
>> > 105 return ret;
>> > 106 }
>> >
>>
>> Okay. I find the reason about this error.
>
> It's getting rather late and we don't seem to have a final set of fixes
> yet. Perhaps the best approach here is to revert and try again for
> 4.18?

Yes. Reverting seems to be a right decision at this moment.
Could you apply original revert patch from Ville?

Thanks.