Re: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()

From: Paul E. McKenney
Date: Tue May 22 2018 - 12:09:53 EST


On Tue, May 22, 2018 at 09:38:13AM -0700, Linus Torvalds wrote:
> On Tue, May 22, 2018 at 2:09 AM Roman Penyaev <
> roman.penyaev@xxxxxxxxxxxxxxxx> wrote:
>
> > Should I resend current patch with more clear comments about how careful
> > caller should be with a leaking pointer?
>
> No. Even if we go your way, there is *one* single user, and that one is
> special and needs to take a lot more care.
>
> Just roll your own version, and make it an inline function like I've asked
> now now many times, and add a shit-ton of explanations of why it's safe to
> use in that *one* situation.
>
> I don't want any crazy and unsafe stuff in the generic header file that
> absolutely *nobody* should ever use.

Completely agreed!

I was perhaps foolishly assuming that they would be making that adjustment
based on earlier emails, but yes, I should have explicitly stated this
requirement in my earlier reply.

Thanx, Paul