Re: [PATCH v2 07/14] mtd: rawnand: qcom: fix null pointer access for erased page detection

From: Abhishek Sahu
Date: Tue May 22 2018 - 09:17:09 EST


On 2018-05-22 12:46, Miquel Raynal wrote:
Hi Abhishek,

On Thu, 3 May 2018 17:50:34 +0530, Abhishek Sahu
<absahu@xxxxxxxxxxxxxx> wrote:

parse_read_errors can be called with only oob_buf in which case
data_buf will be NULL. If data_buf is NULL, then donât
treat this page as completely erased in case of ECC uncorrectable
error for RS ECC. For BCH ECC, the controller itself tells
regarding erased page in status register.

Signed-off-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>
---
* Changes from v1:

1. Added more detail in commit message
2. Added comment before each if/else

Again, thanks for that.


drivers/mtd/nand/raw/qcom_nandc.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)

Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks Miquel for your review.

Regards,
Abhishek