Re: [PATCH v2 0/2] Add support for QCOM cpufreq FW driver

From: Viresh Kumar
Date: Mon May 21 2018 - 01:10:31 EST


On 19-05-18, 23:04, Taniya Das wrote:
> [v2]
> * Address comments given in v0 series.

That's not how you do it. You need to explain every change in enough
detail here so that the reviewers don't need to go to their previous
emails to see what changed.

> [v1]
> * Fixed compilation reported by Amit K.
>
> The CPUfreq FW present in some QCOM chipsets offloads the steps necessary
> for changing the frequency of CPUs. The driver implements the cpufreq
> driver interface for this firmware.
>
> Taniya Das (2):
> dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings
> cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver
>
> .../bindings/cpufreq/cpufreq-qcom-fw.txt | 68 +++++
> drivers/cpufreq/Kconfig.arm | 9 +
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/qcom-cpufreq-fw.c | 317 +++++++++++++++++++++
> 4 files changed, 395 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-fw.txt
> create mode 100644 drivers/cpufreq/qcom-cpufreq-fw.c
>
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.

--
viresh