Re: [PATCH v3 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

From: Andrey Smirnov
Date: Sun May 20 2018 - 17:29:33 EST


On Sat, May 19, 2018 at 11:26 PM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
> On Sat, May 19, 2018 at 03:35:55PM -0700, Andrey Smirnov wrote:
>> On Tue, Apr 10, 2018 at 11:32 AM, Andrey Smirnov
>> <andrew.smirnov@xxxxxxxxx> wrote:
>> > Platform device core assumes the ownership of dev.platform_data as
>> > well as that it is dynamically allocated and it will try to kfree it
>> > as a part of platform_device_release(). Change the code to use
>> > platform_device_add_data() n instead of a pointer to a static memory
>> > to avoid causing a BUG() when calling platform_device_put().
>> >
>> > The problem can be reproduced by artificially enabling the error path
>> > of platform_device_add() call (around line 357).
>> >
>> > Note that this change also allows us to constify imx7_pgc_domains,
>> > since we no longer need to be able to modify it.
>> >
>>
>> Shawn,
>>
>> What's the status of these two patches? Do I need to change anything
>> or are they good to go?
>
> The patches were queued on imx/drivers branch for a while. I forgot to
> let you know. Sorry.
>

No worries and good to know!

Thanks,
Andrey Smirnov