Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

From: Joey Pabalinas
Date: Fri May 18 2018 - 06:55:59 EST


On Fri, May 18, 2018 at 08:03:26PM +0900, Masahiro Yamada wrote:
> Does this work?
> ALLSOURCE_ARCHS=$(find "${tree}"arch -mindepth 1 -maxdepth 1 -type d
> -printf ' %f')

Aha, that actually works perfectly.

> It would leave one leading space, but I do not think it is a big deal.
>
>
> It would be possible to chop it like follows, but I wonder if it is worth doing.
> ALLSOURCE_ARCHS=$(find "${tree}"arch -mindepth 1 -maxdepth 1 -type d
> -printf ' %f' | cut -c2-)

Yeah, the leading space isn't really something that is worth worrying
about here in my opinion either.

I'll use this in my v4 then, thanks.

--
Cheers,
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature