Re: [PATCH V2 04/20] x86: kcore: Give entry trampolines all the same offset in kcore

From: Dave Hansen
Date: Thu May 17 2018 - 12:57:42 EST


On 05/17/2018 02:21 AM, Adrian Hunter wrote:
> @@ -149,9 +149,9 @@ static void __init setup_cpu_entry_area(int cpu)
>
> cea_set_pte(&get_cpu_entry_area(cpu)->entry_trampoline,
> __pa_symbol(_entry_trampoline), PAGE_KERNEL_RX);
> - kclist_add(&per_cpu(kcore_entry_trampoline, cpu),
> - &get_cpu_entry_area(cpu)->entry_trampoline, PAGE_SIZE,
> - KCORE_TEXT);
> + kclist_add_remap(&per_cpu(kcore_entry_trampoline, cpu),
> + _entry_trampoline,
> + &get_cpu_entry_area(cpu)->entry_trampoline, PAGE_SIZE);
> #endif
> percpu_setup_debug_store(cpu);
> }

Why do you bother adding then immediately removing this code?