Re: [PATCH 4.4 115/190] Fix serial console on SNI RM400 machines

From: Greg Kroah-Hartman
Date: Thu May 17 2018 - 04:30:05 EST


On Thu, May 17, 2018 at 11:04:28AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 16, 2018 at 01:15:48AM +0100, Ben Hutchings wrote:
> > On Wed, 2018-04-11 at 20:36 +0200, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> > >
> > >
> > > [ Upstream commit e279e6d98e0cf2c2fe008b3c29042b92f0e17b1d ]
> > >
> > > sccnxp driver doesn't get the correct uart clock rate, if CONFIG_HAVE_CLOCK
> > > is disabled. Correct usage of clk API to make it work with/without it.
> > >
> > > Fixes: 90efa75f7ab0 (serial: sccnxp: Using CLK API for getting UART clock)
> > [...]
> >
> > There's another related fix upstream:
> >
> > commit c91261437985d481c472639d4397931d77f5d4e9
> > Author: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> > Date:   Sat Sep 2 23:13:55 2017 +0300
> >
> >     serial: sccnxp: Fix error handling in sccnxp_probe()
> >
> > Ben.
>
> Thanks, now queued up.

Nope, breaks the build :(

I'll leave it as-is, this is a very low-frequency path.

thanks,

greg k-h