Re: [PATCH v2 10/14] tracing: Document trace_marker triggers

From: Steven Rostedt
Date: Wed May 16 2018 - 10:53:55 EST


On Wed, 16 May 2018 10:22:27 -0500
Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:

> Sure, but noticed in the new version you just posted, that this line is
> still in there for your second example:
>
> + # echo '!hist:keys=common_pid:vals=hitcount:lat=common_timestamp.usecs-$ts0:sort=hitcount:size=2048:clock=global:onmatch(sched.sched_switch).latency($lat) if buf == "end"' > events/ftrace/print/trigger
>
> Did you intend that, or am I missing something?

No, I am. From my reply, you can see I skipped it. I totally missed
that comment. I'll update that too.


>
> Anyway, you have my
>
> Reviewed-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>

Thanks!

-- Steve