Re: [PATCH v2 14/14] tracing/selftest: Add test to test hist trigger between kernel event and trace_marker

From: Steven Rostedt
Date: Wed May 16 2018 - 09:37:26 EST


On Wed, 16 May 2018 18:11:53 +0900
Namhyung Kim <namhyung@xxxxxxxxxx> wrote:


> > +echo "Test histogram kernel event to trace_marker latency histogram trigger"
> > +
> > +echo 'latency u64 lat' > synthetic_events
> > +echo 'hist:keys=pid:ts0=common_timestamp.usecs' > events/sched/sched_waking/trigger
> > +echo 'hist:keys=common_pid:lat=common_timestamp.usecs-$ts0:onmatch(ftrace.print).latency($lat)' > events/ftrace/print/trigger
>
> Shouldn't it be "onmatch(sched.sched_waking)" ?

Ug, yes! Cut-and-paste fail :-p

I tested this my hand and did it correctly, but instead of
cut-and-pasting the command line, I cut and pasted the other test and
updated it.

Thanks for reviewing Namhyung!

-- Steve