Re: [PATCH] random: remove unused argument from add_interrupt_randomness()

From: kbuild test robot
Date: Mon Apr 30 2018 - 02:17:50 EST


Hi Sultan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Sultan-Alsawaf/random-remove-unused-argument-from-add_interrupt_randomness/20180430-111445
config: i386-randconfig-x013-201817 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers/hv/hv.c: In function 'hv_stimer0_isr':
>> drivers/hv/hv.c:118:2: error: too many arguments to function 'add_interrupt_randomness'
add_interrupt_randomness(stimer0_vector, 0);
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/hv/hv.c:30:0:
include/linux/random.h:35:13: note: declared here
extern void add_interrupt_randomness(int irq) __latent_entropy;
^~~~~~~~~~~~~~~~~~~~~~~~

vim +/add_interrupt_randomness +118 drivers/hv/hv.c

3e7ee490 drivers/staging/hv/Hv.c Hank Janssen 2009-07-13 105
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 106 /*
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 107 * ISR for when stimer0 is operating in Direct Mode. Direct Mode
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 108 * does not use VMbus or any VMbus messages, so process here and not
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 109 * in the VMbus driver code.
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 110 */
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 111
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 112 static void hv_stimer0_isr(void)
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 113 {
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 114 struct hv_per_cpu_context *hv_cpu;
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 115
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 116 hv_cpu = this_cpu_ptr(hv_context.cpu_context);
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 117 hv_cpu->clk_evt->event_handler(hv_cpu->clk_evt);
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 @118 add_interrupt_randomness(stimer0_vector, 0);
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 119 }
248e742a drivers/hv/hv.c Michael Kelley 2018-03-04 120

:::::: The code at line 118 was first introduced by commit
:::::: 248e742a396e7f00b283f1c56e14b1bef6e3ec56 Drivers: hv: vmbus: Implement Direct Mode for stimer0

:::::: TO: Michael Kelley <mhkelley@xxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip