Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

From: Michal Hocko
Date: Fri Apr 27 2018 - 04:26:04 EST


On Thu 26-04-18 18:52:05, Mikulas Patocka wrote:
>
>
> On Fri, 27 Apr 2018, Michael S. Tsirkin wrote:
[...]
> > But assuming it's important to control this kind of
> > fault injection to be controlled from
> > a dedicated menuconfig option, why not the rest of
> > faults?
>
> The injected faults cause damage to the user, so there's no point to
> enable them by default. vmalloc fallback should not cause any damage
> (assuming that the code is correctly written).

But you want to find those bugs which would BUG_ON easier, so there is a
risk of harm IIUC and this is not much different than other fault
injecting paths.
--
Michal Hocko
SUSE Labs