Re: [PATCH] net: phy: marvell: clear wol event before setting it

From: Jisheng Zhang
Date: Fri Apr 27 2018 - 03:23:53 EST


On Fri, 27 Apr 2018 09:22:34 +0530 Bhadram Varka wrote:

> Hi Andrew/Jisheng,
>
> On 4/26/2018 6:10 PM, Andrew Lunn wrote:
> >> hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel
> >> requires WOL should be "stick".
> > I see two different cases:
> >
> > Suspend/resume: The WoL state in the kernel is probably kept across
> > such a cycle. If so, you would expect another suspend/resume to also
> > work, without needs to reconfigure it.
> Trying this scenario (suspend/resume) from my side. In this case WoL
> should be enabled in the HW. For Marvell PHY to generate WoL interrupt
> we need to clear WoL status.
> Above mentioned change required to make this happen. Please share your
> thoughts on this.

I'm fine with that patch. Maybe you could send out a patch?

Thanks