Re: [PATCH] USB: serial: option: adding support for ublox R410M

From: Johan Hovold
Date: Thu Apr 26 2018 - 04:14:38 EST


On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote:
> On 4/26/2018 14:09, Johan Hovold wrote:
> > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (æäæ) wrote:
> >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option
> >> driver, this module supports LTE Cat M1 / NB1.
> >>
> >> Interface layout:
> >> 0: QCDM/DIAG
> >> 1: ADB
> >> 2: AT
> >> 3: RMNET
> >>
> >> Signed-off-by: SZ Lin (æäæ) <sz.lin@xxxxxxxx>
> >> Cc: stable <stable@xxxxxxxxxxxxxxx>
> >
> > Applied, thanks.
> >
> > Johan
>
> With a Qualcomm Device Management interface, shouldn't this modem be
> driven by qcserial?

Hmm, we already have some QCDM interfaces handled by option and qcaux so
it's not that clear-cut.

Dan and BjÃrn had a discussion about this a while back, so adding them
on CC. It seems to me that this device does not fit the intended use (or
Gobi 1000 layout) for qcserial, but I may be mistaken.

Thanks,
Johan