RE: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support

[Anson Huang]

Hi, Fabio

Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
> Sent: Thursday, April 26, 2018 5:46 AM
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer
> <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; Rob
> Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>; dl-linux-imx
> <linux-imx@xxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; open list:OPEN
> FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander
> max7310 support
> 
> On Wed, Apr 25, 2018 at 2:36 AM, Anson Huang <Anson.Huang@xxxxxxx>
> wrote:
> 
> > +&i2c3 {
> > +       clock-frequency = <100000>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_i2c3_2>;
> > +       status = "okay";
> > +
> > +       max7310_a: gpio@30 {
> > +               compatible = "maxim,max7310";
> > +               reg = <0x30>;
> > +               gpio-controller;
> > +               #gpio-cells = <2>;
> > +       };
> > +
> > +       max7310_b: gpio@32 {
> > +               compatible = "maxim,max7310";
> > +               reg = <0x32>;
> > +               gpio-controller;
> > +               #gpio-cells = <2>;
> > +       };
> 
> Please also add the users for the MAX7310 pins, such as Ethernet PHY.
 
MAX7310 pins are for PCIe, CAN, MLB. GPS etc., these modules are NOT enabled yet, so
I can NOT test it, I think we should add MAX7310 users when these modules are enabled,
ethernet PHY is NOT controlled by it.

Anson.