Re: [PATCH] fsl/fman_port: remove redundant check on port->rev_info.major

From: David Miller
Date: Tue Apr 24 2018 - 16:01:20 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 24 Apr 2018 12:39:45 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The check port->rev_info.major >= 6 is being performed twice, thus
> the inner second check is always true and is redundant, hence it
> can be removed. Detected by cppcheck.
>
> drivers/net/ethernet/freescale/fman/fman_port.c:1394]: (warning)
> Identical inner 'if' condition is always true.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to net-next, thank you.