Re: [PATCH 0/8] Fix year 2038 issue for sound subsystem

From: Arnd Bergmann
Date: Tue Apr 24 2018 - 09:29:48 EST


On Tue, Apr 24, 2018 at 2:06 PM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> Since many structures will use timespec type variables to record time stamp
> in uapi/asound.h, which are not year 2038 safe on 32bit system. This patchset
> tries to introduce new structures removing timespec type to compatible native
> mode and compat mode.
>
> Moreover this patchset also converts the internal structrures to use timespec64
> type and related APIs.
>
> Arnd Bergmann (2):
> ALSA: move snd_pcm_ioctl_sync_ptr_compat into pcm_native.c
> ALSA: add new 32-bit layout for snd_pcm_mmap_status/control
>
> Baolin Wang (6):
> ALSA: Replace timespec with timespec64
> ALSA: Avoid using timespec for struct snd_timer_status
> ALSA: Avoid using timespec for struct snd_ctl_elem_value
> ALSA: Avoid using timespec for struct snd_pcm_status
> ALSA: Avoid using timespec for struct snd_rawmidi_status
> ALSA: Avoid using timespec for struct snd_timer_tread

Thanks a lot for picking this up again and including my two patches!

I've done a private review yesterday, but will have another look either
today or tomorrow to see if I missed anything. I've also applied the
series to my randconfig build tree and will see if that finds any new
bugs. The builder has already found a bug in one of my two patches,
so there might be more.

Arnd