Re: [PATCH 3/9] perf stat: Keep the / modifier separator in fallback

From: Arnaldo Carvalho de Melo
Date: Mon Apr 23 2018 - 10:16:38 EST


Em Mon, Apr 23, 2018 at 11:08:17AM +0200, Jiri Olsa escreveu:
> The perf stat fallback for EACCES error sets exclude_kernel
> for event and repeats the open. In addition, it also changes
> the name of the event to reflect that change by adding the
> 'u' modifier.
>
> But it does not take into account the '/' separator, so the
> event name can end up mangled, like:
> (note the '/:' characters)
>
> $ perf stat -e cpu/cpu-cycles/ kill
> ...
> 386,832 cpu/cpu-cycles/:u
>
> Adding the code to check on the '/' separatos and set
> following event name:
>
> $ perf stat -e cpu/cpu-cycles/ kill
> ...
> 388,548 cpu/cpu-cycles/u

Thanks, tested, reproduced and applied to perf/urgent

- Arnaldo