Re: [PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm_t'.

From: Greg KH
Date: Mon Apr 23 2018 - 08:13:39 EST


On Fri, Mar 30, 2018 at 11:07:50PM -0700, Quytelda Kahja wrote:
> 'struct hostif_mib_get_confirm_t' is not used in this driver. Remove
> 'struct hostif_mib_get_confirm_t'.
>
> Signed-off-by: Quytelda Kahja <quytelda@xxxxxxxxxxx>
> ---
> drivers/staging/ks7010/ks_hostif.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
> index aedc832bc04c..e6d6c51ccc43 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -151,16 +151,10 @@ struct hostif_mib_value {
> u8 body[0];
> } __packed;
>
> -struct hostif_mib_get_confirm_t {
> - struct hostif_hdr header;
> - __le32 mib_status;
> #define MIB_SUCCESS 0
> #define MIB_INVALID 1
> #define MIB_READ_ONLY 2
> #define MIB_WRITE_ONLY 3

You should have also removed these #defines as they are not used
anywhere either.

thanks,

greg k-h