Re: [PATCH] printk: Ratelimit messages printed by console drivers

From: Steven Rostedt
Date: Mon Apr 23 2018 - 07:36:14 EST


On Mon, 23 Apr 2018 12:32:32 +0200
Petr Mladek <pmladek@xxxxxxxx> wrote:

> > Really?
> >
> >
> > console_trylock_spinning(); /* console_owner now equals current */
>
> No, console_trylock_spinning() does not modify console_owner. The
> handshake is done using console_waiter variable.

Ug, you're right. Somehow when I looked at where console_owner was set
"console_lock_spinning_enabled" I saw it as "console_trylock_spinning".

This is what I get when I'm trying to follow three threads at the same
time :-/

>
> console_owner is really set only between:
>
> console_lock_spinning_enable()
> console_lock_spinning_disable_and_check()
>
> and this entire section is called with interrupts disabled.

OK, I agree with you now. Although, one hour may still be too long.

-- Steve