Re: [PATCH net] vmxnet3: fix incorrect dereference when rxvlan is disabled

From: David Miller
Date: Thu Apr 19 2018 - 14:00:03 EST


From: Ronak Doshi <doshir@xxxxxxxxxx>
Date: Wed, 18 Apr 2018 12:48:04 -0700

> vmxnet3_get_hdr_len() is used to calculate the header length which in
> turn is used to calculate the gso_size for skb. When rxvlan offload is
> disabled, vlan tag is present in the header and the function references
> ip header from sizeof(ethhdr) and leads to incorrect pointer reference.
>
> This patch fixes this issue by taking sizeof(vlan_ethhdr) into account
> if vlan tag is present and correctly references the ip hdr.
>
> Signed-off-by: Ronak Doshi <doshir@xxxxxxxxxx>
> Acked-by: Guolin Yang <gyang@xxxxxxxxxx>
> Acked-by: Louis Luo <llouis@xxxxxxxxxx>

Applied and queued up for -stable, thanks.

Please provide an appropriate Fixes: tag next time.