Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

From: Andrew Morton
Date: Wed Apr 18 2018 - 18:28:28 EST


On Thu, 5 Apr 2018 21:26:51 +0300 Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> Subject: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

s/Deprecate/remove/ !

> An ability to manipulate mm_struct fields was introduced in
> sake of CRIU in first place. Later we provide more suitable
> and safe operation PR_SET_MM_MAP where all fields to be modifed
> are passed in one structure which allows us to make more detailed
> verification.
>
> Still old interface remains present for compatibility reason
> though CRIU itself already switched to PR_SET_MM_MAP on its
> own long ago.
>
> Googling didn't reveal some other users of this operation
> so I think it should be safe to remove this interface.

It does seem a bit sudden. We could just add a "this interface is
scheduled for removal" warning, then delete the code for real later in
the year. To give people time to migrate or to complain to us.