Re: [RESEND PATCH] drivers: change struct device_driver::coredump() return type to void

From: Arend van Spriel
Date: Wed Apr 18 2018 - 15:11:32 EST


On Sun, Apr 8, 2018 at 11:57 PM, Arend van Spriel <aspriel@xxxxxxxxx> wrote:
> Upon submitting a patch for mwifiex [1] it was discussed whether this
> callback function could fail. To keep things simple there is no need
> for the error code so the driver can do the task synchronous or not
> without worries. Currently the device driver core already ignores the
> return value so changing it to void.
>
> [1] https://patchwork.kernel.org/patch/10231933/
>
> Signed-off-by: Arend van Spriel <aspriel@xxxxxxxxx>
> ---
> Hi Greg,
>
> Here is a resend of my patch that got lost. See if it makes it
> this time ;-)

Hi Greg,

Your patch-bot replied to this one and I may be overly anxious, but
that's because things ran haywire in the initial submission. So is the
patch in your queue for 4.17?

Regards,
Arend

> Regards,
> Arend
> ---
> include/linux/device.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)