RE: Re: [PATCH] PM / devfreq: use put_device() instead of kfree()

[MyungJoo Ham]

>On 2018ë 04ì 13ì 11:37, arvindY wrote:
>> On Friday 13 April 2018 07:59 AM, Chanwoo Choi wrote:
>>> On 2018ë 04ì 13ì 11:15, arvindY wrote:
>>>> On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote:
>>>>> On 2018ë 04ì 13ì 10:03, Chanwoo Choi wrote:
[]
>>>>>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>>>>>>> index fe2af6a..a225b94 100644
>>>>>>> --- a/drivers/devfreq/devfreq.c
>>>>>>> +++ b/drivers/devfreq/devfreq.c
>>>>>>> @@ -625,7 +625,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>>>>>>        err = device_register(&devfreq->dev);
>>>>>>>        if (err) {
>>>>>>>            mutex_unlock(&devfreq->lock);
>>>>>>> -        goto err_dev;
>>>>>>> +        put_device(&devfreq->dev);
>>>>>>> +        goto err_out;
>>>>>>>        }
>>>>>>>          devfreq->trans_table =    devm_kzalloc(&devfreq->dev,
>>>>>>> @@ -671,6 +672,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>>>>>>        mutex_unlock(&devfreq_list_lock);
>>>>>>>          device_unregister(&devfreq->dev);
>>>>>>> +    devfreq = NULL;
>>>>>>>    err_dev:
>>>>>>>        if (devfreq)
>>>>>>>            kfree(devfreq);
>>>>>>>

Ah.. this was critcal. Thanks!

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

>Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>


Cheers,
MyungJoo