Re: [PATCH net-next 2/3] net: phy: Change the array size to 32 for device_ids

From: Florian Fainelli
Date: Tue Apr 17 2018 - 14:19:00 EST


On 04/17/2018 02:02 AM, Vicentiu Galanopulo wrote:
> In the context of enabling the discovery of the PHYs
> which have the C45 MDIO address space in a non-standard
> address: num_ids in get_phy_c45_ids, has the
> value 8 (ARRAY_SIZE(c45_ids->device_ids)), but the
> u32 *devs can store 32 devices in the bitfield.
>
> If a device is stored in *devs, in bits 32 to 9
> (bit counting in lookup loop starts from 1), it will
> not be found.
>
> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@xxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian