Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset

From: Matt Redfearn
Date: Tue Apr 17 2018 - 09:20:06 EST


Hi James,

On 16/04/18 21:22, James Hogan wrote:
On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote:
@@ -260,6 +260,11 @@
jr ra
andi v1, a2, STORMASK

This patch looks good, well spotted!

But whats that v1 write about? Any ideas? Seems to go back to the git
epoch, and $3 isn't in the clobber lists when __bzero* is called.

No idea what the original intent was, but I've verified that v1 does indeed get clobbered if this path is hit. Patch incoming!

Thanks,
Matt


Cheers
James

+.Lsmall_fixup\@:
+ PTR_SUBU a2, t1, a0
+ jr ra
+ PTR_ADDIU a2, 1
+