Re: [PATCH v3] selftests/livepatch: introduce tests

From: Miroslav Benes
Date: Tue Apr 17 2018 - 04:06:32 EST


On Mon, 16 Apr 2018, Petr Mladek wrote:

> On Mon 2018-04-16 13:33:55, Miroslav Benes wrote:
> > On Fri, 13 Apr 2018, Joe Lawrence wrote:
> > > Thanks for reviewing. I'll hold off on posting v4 until Petr (and
> > > others) get a chance to comment. Perhaps there are other tests that
> > > would be helpful?
>
> > I think it would be useful to have tests for a stack checking and a
> > consistency. Nicolai has written some lately for our internal testing, but
> > it would take some time to transform them appropriately, I think.
>
> The future of the stack handling is not clear at the moment. We should
> wait how the discussion goes before spending time on test cases for
> the current behavior.

You're talking about something different. We have to check stacks of all
tasks while patching in order to achieve consistency. Tests for that would
be useful.

Miroslav