Re: [PATCH] soc: qcom: cmd-db: Make endian-agnostic

[Evan Green]

On Thu, Apr 12, 2018 at 3:41 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:

> This driver deals with memory that is stored in little-endian format.
> Update the structures with the proper little-endian types and then
> do the proper conversions when reading the fields. Note that we compare
> the ids with a memcmp() because we already pad out the string 'id' field
> to exactly 8 bytes with the strncpy() onto the stack.

> Cc: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx>
> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: Evan Green <evgreen@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> ---

> Changes from inline patch:
>   * Fixed magic
>   * Made function for memcmp()
>   *

>   drivers/soc/qcom/cmd-db.c | 116 +++++++++++++++++++++-----------------
>   1 file changed, 65 insertions(+), 51 deletions(-)

> Sent by a computer through tubes


Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>