Re: [PATCH] radix tree test suite: fix mapshift build target

From: Andrew Morton
Date: Thu Apr 12 2018 - 17:15:51 EST


On Thu, 12 Apr 2018 15:05:18 -0600 Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> wrote:

> The following commit
>
> commit c6ce3e2fe3da ("radix tree test suite: Add config option for map
> shift")
>
> Introduced a phony makefile target called 'mapshift' that ends up
> generating the file generated/map-shift.h. This phony target was then
> added as a dependency of the top level 'targets' build target, which is
> what is run when you go to tools/testing/radix-tree and just type 'make'.
>
> Unfortunately, this phony target doesn't actually work as a dependency, so
> you end up getting:
>
> $ make
> make: *** No rule to make target 'generated/map-shift.h', needed by 'main.o'. Stop.
> make: *** Waiting for unfinished jobs....
>
> Fix this by making the file generated/map-shift.h our real makefile target,
> and add this a dependency of the top level build target.

I still get

akpm3:/usr/src/25/tools/testing/radix-tree> make
cc -I. -I../../include -g -O2 -Wall -D_LGPL_SOURCE -fsanitize=address -c -o main.o main.c
In file included from ./linux/../../../../include/linux/radix-tree.h:28:0,
from ./linux/radix-tree.h:6,
from main.c:10:
./linux/rcupdate.h:5:10: fatal error: urcu.h: No such file or directory
#include <urcu.h>


lots of breakage here :(