Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.

From: Boris Brezillon
Date: Thu Apr 12 2018 - 05:15:26 EST


On Mon, 9 Apr 2018 13:58:13 -0700
Eric Anholt <eric@xxxxxxxxxx> wrote:

> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 94b99c90425a..7c95ed5c5cac 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -130,6 +130,7 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
> struct vc4_file *vc4file = file->driver_priv;
>
> vc4_perfmon_close_file(vc4file);
> + kfree(vc4file);
> }
>
> static const struct vm_operations_struct vc4_vm_ops = {