Re: [PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.

From: Dan Carpenter
Date: Wed Apr 11 2018 - 14:32:37 EST


On Wed, Apr 11, 2018 at 10:49:47AM -0700, Greg Hartman wrote:
> > + /* Ensure that the offset is within shared memory */
> > + if (((uint64_t)arg->offset) + region_p->region_begin_offset +
> > + sizeof(uint32_t) > region_p->region_end_offset)
>
> I'm not certain if I understand the overflow.
>
> arg->offset, region_begin_offset, and region_end_offset are all uint32.
>

Ah... You're right. I didn't read carefully. Sorry for the noise.

regards,
dan carpenter