Re: [PATCH v3 1/4] gpio: pca953x: set the PCA_PCAL flag also when matching by DT

From: Andy Shevchenko
Date: Tue Apr 10 2018 - 14:08:46 EST


On Tue, Apr 10, 2018 at 7:07 PM, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote:
> The of_device_table is missing the PCA_PCAL flag so the
> pcal6524 would be operated in tca6424 compatibility mode which
> does not handle the new interrupt mask registers.


> + { .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_INT |
> + PCA_PCAL), },
> + { .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_INT |
> + PCA_PCAL), },

Sorry didn't comment this earlier, though I think one line still
better to read disregard of 80 char limit.


--
With Best Regards,
Andy Shevchenko