Re: [PATCH 2/3] objtool: Support HOSTCFLAGS and HOSTLDFLAGS

[Laura Abbott]

On 04/04/2018 09:42 PM, Masahiro Yamada wrote:
> 2018-03-29 9:48 GMT+09:00 Laura Abbott <labbott@xxxxxxxxxx>:
> > It may be useful to compile host programs with different flags (e.g.
> > hardening). Ensure that objtool picks up the appropriate flags.
> >
> > Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> > ---
>
>
> I saw some similar patches before.
>
> I thought they are fixing this way
> https://patchwork.kernel.org/patch/10251259/
>
> but, I am not tacking the progress.

That looks like a different issue since it's still not going to
pick up the HOST{C,LD}FLAGS.

> >   tools/objtool/Makefile | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> > index e6acc281dd37..0ff3bcac1ca9 100644
> > --- a/tools/objtool/Makefile
> > +++ b/tools/objtool/Makefile
> > @@ -31,8 +31,9 @@ INCLUDES := -I$(srctree)/tools/include \
> >              -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
> >              -I$(srctree)/tools/objtool/arch/$(ARCH)/include
> >   WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
> > -CFLAGS   += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
> > -LDFLAGS  += -lelf $(LIBSUBCMD)
> > +CFLAGS   += -Wall -Werror $(WARNINGS) $(HOSTCFLAGS) -fomit-frame-pointer -O2 -g \
> > +           $(INCLUDES)
> > +LDFLAGS  += -lelf $(LIBSUBCMD) $(HOSTLDFLAGS)
> >
> >   # Allow old libelf to be used:
> >   elfshdr := $(shell echo '\#include <libelf.h>' | $(CC) $(CFLAGS) -x c -E - | grep elf_getshdr)
> > --
> > 2.16.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html