Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

From: gregkh
Date: Thu Apr 05 2018 - 12:12:19 EST


On Thu, Apr 05, 2018 at 03:35:30PM +0000, Ruxandra Ioana Ciocoi Radulescu wrote:
> > -----Original Message-----
> > From: Andrew Lunn [mailto:andrew@xxxxxxx]
> > Sent: Thursday, April 5, 2018 6:24 PM
> > To: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> > Cc: Stuart Yoder <stuyoder@xxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>;
> > Ioana Ciornei <ioana.ciornei@xxxxxxx>; gregkh
> > <gregkh@xxxxxxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> > kernel@xxxxxxxxxxxxxxx>; Ruxandra Ioana Ciocoi Radulescu
> > <ruxandra.radulescu@xxxxxxx>; Razvan Stefanescu
> > <razvan.stefanescu@xxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx>;
> > Networking <netdev@xxxxxxxxxxxxxxx>
> > Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
> >
> > On Thu, Apr 05, 2018 at 02:43:29PM +0000, Laurentiu Tudor wrote:
> > > Hi Andrew,
> > >
> > > On 04/05/2018 03:48 PM, Andrew Lunn wrote:
> > > >>> Hi Laurentiu
> > > >>>
> > > >>> So i can use switchdev without it? I can modprobe the switchdev
> > > >>> driver, all the physical interfaces will appear, and i can use ip addr
> > > >>> add etc. I do not need to use a user space tool at all in order to use
> > > >>> the network functionality?
> > > >>
> > > >> Absolutely!
> > > >
> > > > Great.
> > > >
> > > > Then the easiest way forwards is to simply drop the IOCTL code for the
> > > > moment. Get the basic support for the hardware into the kernel
> > > > first. Then come back later to look at dynamic behaviour which needs
> > > > some form of configuration.
> > >
> > > Hmm, not sure I understand. We already have a fully functional ethernet
> > > driver [1] and a switch driver [2] ...
> >
> > In staging, the tree of crap. You want to get it out of there and into
> > the main tree. But that effort is being side lined by the discussion
> > around this IOCTL call. The best way forward is to to accept Greg is
> > not going to take this patchset at the moment, and move on. As you
> > said, it is not needed for the Ethernet and switchdev driver.
> >
> > What needs to happen before the Ethernet driver can be reviewed for
> > moving out of staging?
>
> Hi Andrew,
>
> We're waiting for the DPIO driver (which we depend on) to be moved
> out of staging first, it's currently under review:
> https://lkml.org/lkml/2018/3/27/1086

That's stalled on my side right now as the merge window is open and I
can't do any new stuff until after 4.17-rc1 is out. So everyone please
be patient a bit...

thanks,

greg k-h