Re: [PATCH v5 01/13] ARM: move cputype definitions into another file

From: Florian Fainelli
Date: Tue Apr 03 2018 - 15:56:49 EST


On 04/02/2018 11:52 PM, Chen-Yu Tsai wrote:
> On Tue, Apr 3, 2018 at 2:18 PM, MylÃne Josserand
> <mylene.josserand@xxxxxxxxxxx> wrote:
>> To add the support for SMP on sun8i-a83t, we will use some
>> definitions in an assembly file so move definitions into
>> another file to separate C functions and macro defintions.
>
> Instead of moving the definitions, you could guard all the C
> stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that.

Which is effectively what this patch does (still waiting for an ACK):

https://patchwork.kernel.org/patch/10239855/

>
> ChenYu
>
>> Signed-off-by: MylÃne Josserand <mylene.josserand@xxxxxxxxxxx>
>> ---
>> arch/arm/include/asm/cputype.h | 94 +-----------------------------------
>> arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


--
Florian