Re: [PATCH 4.4 088/134] ARM: dts: am335x-pepper: Fix the audio CODECs reset pin

From: Ben Hutchings
Date: Sun Apr 01 2018 - 16:48:28 EST


On Mon, 2018-03-19 at 19:06 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: "Andrew F. Davis" <afd@xxxxxx>
>
>
> [ Upstream commit e153db03c6b7a035c797bcdf35262586f003ee93 ]
>
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.

This doesn't work without commit a825f31f9328 ("ASoC: tlv320aic31xx:
Use standard reset GPIO OF name") which went into 4.16. Please revert
this for all stable branches.

Ben.

> Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board")
>
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Âarch/arm/boot/dts/am335x-pepper.dts |ÂÂÂÂ2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -139,7 +139,7 @@
> Â&audio_codec {
> Â status = "okay";
> Â
> - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> Â AVDD-supply = <&ldo3_reg>;
> Â IOVDD-supply = <&ldo3_reg>;
> Â DRVDD-supply = <&ldo3_reg>;

--
Ben Hutchings
Software Developer, Codethink Ltd.