Re: [PATCH] perf tools: Add a dso_size option to perf report --sort

[Arnaldo Carvalho de Melo]

Em Tue, Mar 27, 2018 at 09:05:07AM -0500, Kim Phillips escreveu:
> On Tue, 27 Mar 2018 04:27:02 -0700
> Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
> 
> > On Tue, Mar 27, 2018 at 06:09:56AM -0500, Kim Phillips wrote:
> > > Add DSO size to perf report/top sort output list.
> > > 
> > > This includes adding a map__size fn to map.h, which is
> > > approximately equal to the DSO data file_size:
> > 
> > What's the point of knowing the size?  
 
> I think it's just an extra convenience over symbol_size (added in
> commit 7768f8dada66d6  "perf tools: Allow sorting by symbol size") for
> tools developers' aggregation statistics.

Yeah, for completeness, may be useful for someone, probably for Maxim?
:-)
 
> > Most of the DSO may not be faulted in. If anything the working
> > set would be more interesting. This would need more changes
> > though.
> 
> Indeed.  Maxim?

Right, that would be another interesting metric to have,

- Arnaldo