Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

From: Philippe Ombredanne
Date: Fri Mar 23 2018 - 13:11:17 EST


Tejun,

On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
>> > v2:
>> > - clarify license version (it should be GPL 2.0)
>> > - use SPDX header
>>
>> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>>
>> Acked-by: Philippe Ombredanne <pombredanne@xxxxxxxx>
>
> I don't think it's a good idea to add this acked-by when it's purely
> based on a single liner license tag. I understand that you want to
> encourage use of the new tags but this can be misleading and it'd be
> great if you reconsider sending out acks like this.
>
> Thanks.


You have a good point. I find it confusing myself.
Please, remove this ack!

--
Cordially
Philippe Ombredanne