Re: [PATCH v3] clk: Add driver for the si544 clock generator chip

From: Stephen Boyd
Date: Fri Mar 23 2018 - 13:04:40 EST


Quoting Mike Looijmans (2018-03-20 01:15:41)
> +
> +static bool is_valid_frequency(const struct clk_si544 *data,
> + unsigned long frequency)
> +{
> + unsigned long max_freq;
> +
> + if (frequency < SI544_MIN_FREQ)
> + return false;
> +
> + switch (data->speed_grade) {
> + case si544a:
> + max_freq = 1500000000;
> + break;
> + case si544b:
> + max_freq = 800000000;
> + break;
> + case si544c:
> + max_freq = 350000000;
> + break;
> + }

Sad. My compiler complains about max_freq being possibly unassigned
here, even though that seems impossible I guess we need to put back the
default case. I'll take care of it when applying and assign max_freq to
0 by default.

Otherwise, applied to clk-next.