Re: [PATCH] mm, vmscan, tracing: Use pointer to reclaim_stat struct in trace event

From: Michal Hocko
Date: Fri Mar 23 2018 - 09:52:33 EST


On Fri 23-03-18 09:47:53, Steven Rostedt wrote:
> On Fri, 23 Mar 2018 14:42:00 +0100
> Michal Hocko <mhocko@xxxxxxxxxx> wrote:
>
> > Yes, the number of parameter is large. struct reclaim_stat is an
> > internal stuff so I didn't want to export it. I do not have strong
> > objections to add it somewhere tracing can find it though.
>
> The one solution is to pull the tracing file
> include/trace/events/vmscan.h into mm/ and have a local header to store
> the reclaim_stat structure that both vmscan.h and vmscan.c can
> reference.

I guess we can live with the public definition as well.

--
Michal Hocko
SUSE Labs